Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make notebook argument in Network.show default to False #274

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

adamcallison
Copy link

@adamcallison adamcallison commented Mar 8, 2024

Currently, the pytest tests fail, due to Network.show being called on Network instances that were initialised with notebook=False, meaning that Network.prep_notebook wasn't called and self.template remains as None. As Network.show's notebook argument defaults to True, it by default attempts to call self.template.render' and errors because None` doesn't have this method.

This PR changes show to default to notebook=False, which follows the pattern used in other methods. The pytest tests now pass.

If notebook=True really is the desired default for show, an alternative is to explicitly set notebook=False in the tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant