Make notebook argument in Network.show default to False #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
pytest
tests fail, due toNetwork.show
being called onNetwork
instances that were initialised withnotebook=False
, meaning thatNetwork.prep_notebook
wasn't called andself.template
remains asNone
. AsNetwork.show
'snotebook
argument defaults toTrue
, it by default attempts to callself.template.render' and errors because
None` doesn't have this method.This PR changes
show
to default tonotebook=False
, which follows the pattern used in other methods. The pytest tests now pass.If
notebook=True
really is the desired default forshow
, an alternative is to explicitly setnotebook=False
in the tests.